Use vcpkg for dependency management #92
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds libsndfile and libsoundio
This reverts commit 3ec40fc. This commit has an error, it uses ${ARCHS_STANDARD} instead of the correct value of $(ARCHS_STANDARD). The reason it still worked was ${ARCHS_STANDARD} is a CMake variable, and is set to "" by default. The parentheses version will work correctly if using Xcode or Makefiles as your build system, but fails with ninja (default build system for CLion).
need to set macOS architectures BEFORE project()
This reverts commit 3616fba.
was Develop, which doesn't match either of the later checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use vcpkg to install and manage dependencies. Vamp is an feature (optional) dependency, which can be enabled in CMakeLists.txt
I have tested this on mac to build C++ and python, needs testing on windows and linux. I think this may remove the special windows build instructions.
———
Making this PR a draft for now as needs testing and discussion.